[Lldb-commits] [lldb] r341339 - [NFC] Use llvm_unreachable instead of lldb::assert

David Bolvansky via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 3 15:08:31 PDT 2018


Author: xbolva00
Date: Mon Sep  3 15:08:30 2018
New Revision: 341339

URL: http://llvm.org/viewvc/llvm-project?rev=341339&view=rev
Log:
[NFC] Use llvm_unreachable instead of lldb::assert 

Summary: Fixes implicit fall through warnings

Reviewers: JDevlieghere, teemperor

Reviewed By: teemperor

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D51601

Modified:
    lldb/trunk/source/Host/common/Editline.cpp

Modified: lldb/trunk/source/Host/common/Editline.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Editline.cpp?rev=341339&r1=341338&r2=341339&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/Editline.cpp (original)
+++ lldb/trunk/source/Host/common/Editline.cpp Mon Sep  3 15:08:30 2018
@@ -526,7 +526,7 @@ int Editline::GetCharacter(EditLineGetCh
         break;
 
       case lldb::eConnectionStatusInterrupted:
-        lldbassert(0 && "Interrupts should have been handled above.");
+        llvm_unreachable("Interrupts should have been handled above.");
 
       case lldb::eConnectionStatusError:        // Check GetError() for details
       case lldb::eConnectionStatusTimedOut:     // Request timed out




More information about the lldb-commits mailing list