[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable	support for ansi escape codes
    Dávid Bolvanský via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Tue Sep  4 06:15:30 PDT 2018
    
    
  
xbolva00 added inline comments.
================
Comment at: source/Core/Debugger.cpp:819
+  consoleMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+  SetUseColor(SetConsoleMode(hConsole, consoleMode));
+#endif
----------------
Should I rewrite it to more clear version like
bool ansi_supported = SetConsoleMode(hConsole, consoleMode);
SetUseColor(ansi_supported);
?
Repository:
  rLLDB LLDB
https://reviews.llvm.org/D51615
    
    
More information about the lldb-commits
mailing list