[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

[Frederic Riss via Phabricator via lldb-commits]

friss added inline comments.


================
Comment at: include/lldb/Symbol/ClangASTContext.h:284
+             ((bool)pack_name == (bool)packed_args) &&
+             (!packed_args || !packed_args->args.empty());
     }
----------------
shafik wrote:
> Is this saying that an empty parameter pack is invalid? We can have an empty parameter pack
> 
> https://godbolt.org/z/8zCFz9
That's a good question. I need to check what the DWARF looks like for an empty parameter pack. I would expect it not to be mentioned at all, but if it's there we need to support it.


================
Comment at: include/lldb/Symbol/GoASTContext.h:313-316
+  size_t GetNumTemplateArguments(lldb::opaque_compiler_type_t type,
+                                 bool expand_pack) override {
     return 0;
   }
----------------
clayborg wrote:
> We should make a default implementation of this function in TypeSystem.h so not every TypeSystem subclass needs to make a do nothing and return 0 function. It will make future changes easier and touch less files.
I've done this in r341006, I'll rebase soon.


https://reviews.llvm.org/D51387