[Lldb-commits] [PATCH] D51445: Remove undefined behavior around the use of StateType

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 29 11:21:24 PDT 2018


jingham added a comment.

I wonder if it is worth asserting if a process ever returns a state of kNumStateType?  I don't think it is necessary in things like StateIsStoppedState, somebody might have found their way here from the SB API's and we want to be forgiving there.  But wherever we've done process->GetState(), that should never come back with kNumStateTypes.  We already have eStateInvalid to mean "The debugger is confused about the state of the process".  So there's never a reason why a process should report its state as kNumStateTypes.


https://reviews.llvm.org/D51445





More information about the lldb-commits mailing list