[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added inline comments.


================
Comment at: source/Core/Debugger.cpp:805
   const char *term = getenv("TERM");
   if (term && !strcmp(term, "dumb"))
     SetUseColor(false);
----------------
teemperor wrote:
> aprantl wrote:
> > aprantl wrote:
> > > Shouldn't this check be obsolete now?
> > You can probably test that by running env TERM=dumb lldb 
> LLVM doesn't seem to check for this environment variable from what I see, so the new code doesn't include this functionality. And it's technically a good thing to check for this, so I think we should let it stay until LLVM also adds this feature.
Just tested it, and the LLVM code indeed ignored TERM=dumb. I'll fix this in LLVM and then we see what people think about this (and if it goes in, we can remove it here).


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51243