[Lldb-commits] [lldb] r340658 - [vscode] Skip some of the vscode tests on Linux and fix one

Stella Stamenova via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 24 14:42:53 PDT 2018


Author: stella.stamenova
Date: Fri Aug 24 14:42:53 2018
New Revision: 340658

URL: http://llvm.org/viewvc/llvm-project?rev=340658&view=rev
Log:
[vscode] Skip some of the vscode tests on Linux and fix one

Summary: These are already skipped on Darwin because they cause build bot failures. Both on the build bots as well as in our testing we have seen a number of these tests fail and hang. This change skips the failing/hanging tests on Linux and also fixes one of the test - the test needs the thread library to build.

Reviewers: asmith, clayborg, aprantl

Subscribers: teemperor, lldb-commits

Differential Revision: https://reviews.llvm.org/D51227

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
    lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py
    lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/step/Makefile

Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py?rev=340658&r1=340657&r2=340658&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py Fri Aug 24 14:42:53 2018
@@ -47,6 +47,7 @@ class TestVSCode_attach(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_by_pid(self):
         '''
@@ -63,6 +64,7 @@ class TestVSCode_attach(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_by_name(self):
         '''
@@ -97,6 +99,7 @@ class TestVSCode_attach(lldbvscode_testc
 
     @skipUnlessDarwin
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_by_name_waitFor(self):
         '''
@@ -114,6 +117,7 @@ class TestVSCode_attach(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_commands(self):
         '''

Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py?rev=340658&r1=340657&r2=340658&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py Fri Aug 24 14:42:53 2018
@@ -21,6 +21,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_default(self):
         '''
@@ -40,6 +41,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_stopOnEntry(self):
         '''
@@ -61,6 +63,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_cwd(self):
         '''
@@ -89,6 +92,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_debuggerRoot(self):
         '''
@@ -118,6 +122,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_sourcePath(self):
         '''
@@ -145,6 +150,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_disableSTDIO(self):
         '''
@@ -161,6 +167,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_shellExpandArguments_enabled(self):
         '''
@@ -186,6 +193,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_shellExpandArguments_disabled(self):
         '''
@@ -213,6 +221,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_args(self):
         '''
@@ -240,6 +249,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_environment(self):
         '''
@@ -274,6 +284,7 @@ class TestVSCode_launch(lldbvscode_testc
 
     @skipIfWindows
     @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin
     @no_debug_info_test
     def test_commands(self):
         '''

Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/step/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/step/Makefile?rev=340658&r1=340657&r2=340658&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/step/Makefile (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/step/Makefile Fri Aug 24 14:42:53 2018
@@ -1,5 +1,7 @@
 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
+
 CXX_SOURCES := main.cpp
 
 include $(LEVEL)/Makefile.rules




More information about the lldb-commits mailing list