[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

Thank you for writing the test. This is more-or-less what I had in mind. Just make sure we don't put the test files in /tmp (e.g., because windows doesn't have it).

It's unfortunate that the core file has my username embedded in it (I should have build this in /tmp or somewhere), but if that doesn't bother you then I'm fine with it too (you can find leftover usernames in some llvm tests too, although, with this test, this becomes a bit more apparent). Alternatively, we can regenerate the core file and the matching executable. (We could use yaml2obj on the executable, but it unfortunately doesn't support (elf) core files at the moment).



================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py:215
+        # /home/labath/test/a.out)
+        tmp_sysroot = "/tmp/lldb_i386_mock_sysroot"
+        executable = tmp_sysroot + "/home/labath/test/a.out"
----------------
Please put this in the build folder (self.getBuildDir) instead of `/tmp`.


================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py:231-232
+
+        # Clean up tmp_sysroot
+        shutil.rmtree(tmp_sysroot)
+
----------------
Then, this will not be necessary.


https://reviews.llvm.org/D49685