[Lldb-commits] [lldb] r339076 - [lit, python] Always add quotes around the python path in lit

[Hans Wennborg via lldb-commits]

Merged to 7.0 in r339657.

On Tue, Aug 7, 2018 at 12:37 AM, Stella Stamenova via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
> Author: stella.stamenova
> Date: Mon Aug  6 15:37:53 2018
> New Revision: 339076
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339076&view=rev
> Log:
> [lit, python] Always add quotes around the python path in lit
>
> Summary:
> The issue with the python path is that the path to python on Windows can contain spaces. To make the tests always work, the path to python needs to be surrounded by quotes.
>
> This is a companion change to: https://reviews.llvm.org/D50206
>
> Reviewers: asmith, zturner
>
> Differential Revision: https://reviews.llvm.org/D50280
>
> Modified:
>     lldb/trunk/lit/lit.cfg
>
> Modified: lldb/trunk/lit/lit.cfg
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/lit.cfg?rev=339076&r1=339075&r2=339076&view=diff
> ==============================================================================
> --- lldb/trunk/lit/lit.cfg (original)
> +++ lldb/trunk/lit/lit.cfg Mon Aug  6 15:37:53 2018
> @@ -54,7 +54,7 @@ config.environment['LLVM_SRC_ROOT'] = ge
>  config.environment['PYTHON_EXECUTABLE'] = getattr(config, 'python_executable', '')
>
>  # Register substitutions
> -config.substitutions.append(('%python', config.python_executable))
> +config.substitutions.append(('%python', "'%s'" % (config.python_executable)))
>
>  debugserver = lit.util.which('debugserver', lldb_tools_dir)
>  lldb = "%s -S %s/lit-lldb-init" % (lit.util.which('lldb', lldb_tools_dir),
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits