[Lldb-commits] [PATCH] D50676: Remove manual byte counting from Highlighter code.

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 13 16:32:01 PDT 2018


teemperor created this revision.

This removes the manual byte counting mechanism from the syntax highlighting
code. This is no longer necessary as the Stream class now has built-in support for
automatically counting the bytes that were written to it so far.

The advantage of automatic byte counting via Stream is that it is less error-prone
than the manual version and we need to write less boilerplate code.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D50676

Files:
  include/lldb/Core/Highlighter.h
  source/Core/Highlighter.cpp
  source/Core/SourceManager.cpp
  source/Plugins/Language/ClangCommon/ClangHighlighter.cpp
  source/Plugins/Language/ClangCommon/ClangHighlighter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50676.160481.patch
Type: text/x-patch
Size: 8717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180813/2fe9d9dc/attachment.bin>


More information about the lldb-commits mailing list