[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:5
+# We should hardcode executable name since at the moment of running of
+# lldb-mi the name must be known.
+# RUN: %cxx -o a.exe %p/inputs/main.cpp -g
----------------
That's totally fine, we just need to choose a name that works on all platforms, and `a.exe` does.


================
Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:18
+target list
+# CHECK: ~"Current targets:\n* target #0: {{.*}}a.exe{{.*}}\n"
+
----------------
Does lldb-mi echo the comment lines? If yes, you need to be careful that FileCheck doesn't match against the input, e.g., by adding `{{^}}` to the beginning of each CHECK command. If it doesn't, then that's fine.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D50525