[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

Stefan Gränitz via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 8 11:49:23 PDT 2018

sgraenitz marked an inline comment as done.
sgraenitz added inline comments.

Comment at: source/Core/Mangled.cpp:239-240
+namespace {
+char *GetMSVCDemangledStr(const char *M) {
jingham wrote:
> The LLVM conventions suggest only putting declarations in the anon namespace, and then having the definitions out of line:
> http://www.llvm.org/docs/CodingStandards.html#anonymous-namespaces
Right. Well that's a C function, so removed anon namespace and declared static.


More information about the lldb-commits mailing list