[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements
Leonard Mosescu via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 6 13:34:19 PDT 2018
lemo added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413
+ return 0;
> This needs to be `std::move(Error)`. If you built with asserts enabled and hit this line, you would crash because you did not consume the `Error` object.
Can you please elaborate? std::move is just a cast (and the result of Error::takeValue() is already an rvalue - the error object has been already moved into a temporary Error instance)
More information about the lldb-commits