[Lldb-commits] [PATCH] D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 6 10:26:15 PDT 2018

jingham added a comment.

This implementation forces an extra lookup when the line number slides.  For instance, if there were only one line match, but it was not exact, you're going to look up the exact address, fail, then look it up with exact = false.

Wouldn't it be more efficient to look with exact = false first, then reset the line you are looking for to whatever you got back, and continue with the exact=true search you do for the other line numbers.


More information about the lldb-commits mailing list