[Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 2 23:28:09 PDT 2018
teemperor added a comment.
I don't see this mentioned here yet, so: This patch also seems to introduce a few hundred warnings with -Wextended-offsetof (which is enabled by default on the macOS builds):
[...]llvm/tools/lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:510:5: warning: using extended field designator is an extension [-Wextended-offsetof]
[...]llvm/tools/lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:67:25: note: expanded from macro 'DEF_S'
"s" #i, nullptr, 4, OFFSET(v[i * 16]), eEncodingVector, \
[...]llvm/tools/lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:29:20: note: expanded from macro 'OFFSET'
#define OFFSET(r) (offsetof(RegisterContextMinidump_ARM64::Context, r))
[...]stddef.h:120:24: note: expanded from macro 'offsetof'
#define offsetof(t, d) __builtin_offsetof(t, d)
(And the tests also fail on macOS, but they are probably fixed when the Linux/Windows tests are fixed).
More information about the lldb-commits