[Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.

[Greg Clayton via Phabricator via lldb-commits]

clayborg marked 2 inline comments as done.
clayborg added inline comments.


================
Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:57
+    nullptr, nullptr, nullptr, 0}
+
+// Zero based LLDB register numbers for this register context
----------------
No need to change the x86. Just seems like more work to map one set of registers to another when/if the actual context is in another format. The ARM registers differ from any other ARM register context as they have 8 "extra" registers, so it didn't make sense to try and map it to another register context. So the "don't like the x86" part is just because it was remapping from one context to another and these register contexts are simple. 


https://reviews.llvm.org/D49750