[Lldb-commits] [PATCH] D50038: Introduce install-lldb-framework target

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I am glad filing the cmake bug has paid off. :)

I just have one small question about this patch.



================
Comment at: cmake/modules/AddLLDB.cmake:81-87
+  # install-liblldb{,-stripped} is the actual target that will install the
+  # framework, so it must rely on the framework being fully built first.
+  if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
+    add_dependencies(install-${name} lldb-framework)
+    add_dependencies(install-lldb-framework-stripped lldb-framework)
+  endif()
+
----------------
Shouldn't this be also guarded under the `NOT LLVM_INSTALL_TOOLCHAIN_ONLY`, like the code above? If someone sets `LLVM_INSTALL_TOOLCHAIN_ONLY=True`, then the install-liblldb target will not even be generated and these lines will fail (or just do something weird).


https://reviews.llvm.org/D50038