[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

Eugene Birukov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 24 15:43:21 PDT 2018


EugeneBi added inline comments.


================
Comment at: source/Target/Platform.cpp:252
+    if (error.Success() && module_sp)
+      module_sp->SetPlatformFileSpec(spec.GetFileSpec());
+    return error;
----------------
EugeneBi wrote:
> A bug here. must be resolved_spec if it succeeds.
Now I have my doubts: what "platform file spec" really means? I mean, which code
is correct: current or previous one?


https://reviews.llvm.org/D49685





More information about the lldb-commits mailing list