[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

Stefan Gränitz via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 24 09:43:03 PDT 2018


sgraenitz updated this revision to Diff 157061.
sgraenitz added a comment.

Change EXPECTED_EQ to EXPECTED_STREQ, because ConstString::operator==() compares identity of pointers, not equality of strings. While "they must come from the same pool in order to be equal" (as stated in the description), this is verifying string equality not the internals of ConstString.


https://reviews.llvm.org/D49612

Files:
  cmake/modules/LLDBConfig.cmake
  lldb.xcodeproj/project.pbxproj
  source/Core/Mangled.cpp
  unittests/Core/CMakeLists.txt
  unittests/Core/MangledTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49612.157061.patch
Type: text/x-patch
Size: 10062 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180724/8f72528f/attachment.bin>


More information about the lldb-commits mailing list