[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 24 09:23:44 PDT 2018


labath added a comment.

I am sure that particular test is worth trying to implement in lit. That script of yours is full of operating system specifics, and it's going to be super flaky.

I'd suggest keeping this as a python test, as there you can abstract the platform specifics much easier, and we also have a lot of code we can (re)use to setup socket connections safely. (e.g. lldb-server has a mode where *it* selects a port to listen on  (race-free), and then you can just fetch that port and connect to it.)

Doing that from a shell script is going to be painful.

I suppose if you really want to make this a lit test, you should at least ditch the bash script and replace that bit with python.


https://reviews.llvm.org/D49739





More information about the lldb-commits mailing list