[Lldb-commits] [PATCH] D49695: [cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 23 13:54:17 PDT 2018


teemperor created this revision.
Herald added a subscriber: mgorny.

LLDB_PLUGINS doesn't exist as a variable, so this line doesn't add any dependencies and is
just confusing. It seems this slipped in from the gdb-remote CMake I was using as a CMake template.

The gdb-remote CMake itself is using a local LLDB_PLUGINS variable, so that code is fine.


https://reviews.llvm.org/D49695

Files:
  source/Host/macosx/objcxx/CMakeLists.txt
  source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt


Index: source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt
===================================================================
--- source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt
+++ source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt
@@ -9,7 +9,6 @@
     lldbSymbol
     lldbTarget
     lldbUtility
-    ${LLDB_PLUGINS}
     ${EXTRA_LIBS}
 
   LINK_COMPONENTS
Index: source/Host/macosx/objcxx/CMakeLists.txt
===================================================================
--- source/Host/macosx/objcxx/CMakeLists.txt
+++ source/Host/macosx/objcxx/CMakeLists.txt
@@ -12,7 +12,6 @@
     lldbSymbol
     lldbTarget
     lldbUtility
-    ${LLDB_PLUGINS}
     ${EXTRA_LIBS}
 
   LINK_COMPONENTS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49695.156868.patch
Type: text/x-patch
Size: 702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180723/5af52304/attachment.bin>


More information about the lldb-commits mailing list