[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil requested changes to this revision.
jankratochvil added inline comments.
This revision now requires changes to proceed.


================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:238
 
+ifneq (,$(wildcard $(DWP)))
+  MAKE_DWP=YES
----------------
I was thinking DWP should be specifiable by user but `make check-lldb DWP=/usr/bin/dwp` has no effect. And `DWP` is not set by any `build*(` functions in `packages/Python/lldbsuite/test/plugins/builder_base.py`, sorry but I do not find that obvious.


================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:528
+ifeq "$(MAKE_DWP)" "YES"
+       $(DWP) -e "$(EXE)" -o "$(EXE).dwp"
+       rm -f $(OBJECTS:.o=.dwo)
----------------
The patch as exported by `Download Raw Diff` says:
```../../../make/Makefile.rules:529: *** missing separator.  Stop.
```
(after forcing it by `DWP=/usr/bin/dwp` in that `Makefile.rules` file)


https://reviews.llvm.org/D48782