[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 17 04:42:47 PDT 2018


aleksandr.urakov added a comment.

Ah, we need some way to synchronize our work :)

I think in this case it will be better to appreciate the pros and cons of our patches, choose the better variant and improve that with the features available in another variant. I will investigate your patch to understand the differences, can you look at my patch too, please?

I agree with Pavel, the test in your patch looks better, than in my one. I think there must be non-execute test in the result patch too.


Repository:
  rL LLVM

https://reviews.llvm.org/D49410





More information about the lldb-commits mailing list