[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Aleksandr Urakov via Phabricator via lldb-commits]

aleksandr.urakov added a comment.

Yes, you are right, extra `location = DW_OP_addr(0000000140004114)` appeared after this commit. But I hadn't noticed that, because the test was already broken for me on `0fa537f42f1af238c74bf41998dc1af31195839a`. Now I have checked one out and ran the test to reveal the cause of the failure. I think it's because of different name mangling. I have attached the output of `lldb-test symbols` to the message. For tests I use the last version of clang-cl (which I build along with lldb), what version do you use (and what version must be used in such cases)?

I think, that updating CHECK-SAME expression to allow `location = {{.*}}` is a good fix for this, because this patch actually adds a location information.

F6714367: symbols.txt <https://reviews.llvm.org/F6714367>


Repository:
  rL LLVM

https://reviews.llvm.org/D49018