[Lldb-commits] [PATCH] D49411: Move from StringRef to std::string in the ScriptInterpreter API

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 16 19:38:44 PDT 2018


teemperor created this revision.
teemperor added a reviewer: dblaikie.

After https://reviews.llvm.org/D49309 it became clear that we always need a null-terminated string (for
the Python API), so we might as well change the API to accept an std::string&
instead of taking a StringRef and then always allocating a new std::string.


https://reviews.llvm.org/D49411

Files:
  include/lldb/Interpreter/ScriptInterpreter.h
  source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.cpp
  source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.h
  source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
  source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49411.155804.patch
Type: text/x-patch
Size: 6241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180717/4d485905/attachment.bin>


More information about the lldb-commits mailing list