[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

Fwiw I’ve seen cases where tests have passed even though they shouldn’t
have — the functionality being tested was broken. The one that comes to
mind was where we were doing a backtrace and then checking that it matched
the regex “main\(argc=3” to make sure the local variable argc had the
correct value. But the actual backtrace was more like mian(argc=3751589203,
...). I.e. a garbage value.

This test passed for months this way until an unrelated change caused argc
to change to a different junk value in the backtrace

This isn’t necessarily the case here, but something to keep in mind.


Repository:
  rL LLVM

https://reviews.llvm.org/D49018