[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

Aaron Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 12 04:42:06 PDT 2018

asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.

Except for minor formatting LGTM

Comment at: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp:7
+  return;
Please remove the return

Comment at: source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h:26
+/// Converts a location information from a PDB symbol to a DWARF expression
Are you sure about the /// ?

Should these be // ?


More information about the lldb-commits mailing list