[Lldb-commits] [PATCH] D49202: Restructure the minidump loading path and add early & explicit consistency checks

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 11 15:23:57 PDT 2018

amccarth added inline comments.

Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:172
+  // Do we support the minidump's architecture?
+  ArchSpec arch = GetArchitecture();
lemo wrote:
> amccarth wrote:
> > Should the architecture check be in the MinidumpParser::Initialize with the other checks?
> > 
> > I don't know the answer; I'm just asking for your thinking about this.
> Good question, here's my take: the checks are for consistency and a minidump with a currently unsupported architecture is a valid minidump. 
> So I think it's better to have this check external since the architecture support is not a minidump parser concern. WDYT?
Yes, this makes sense to me.


More information about the lldb-commits mailing list