[Lldb-commits] [PATCH] D49202: Restructure the minidump loading path and add early & explicit consistency checks

Leonard Mosescu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 11 13:03:20 PDT 2018

lemo created this revision.
lemo added reviewers: amccarth, labath.
lemo added a project: LLDB.
Herald added a subscriber: mgrang.

Corrupted minidumps was leading to unpredictable behavior.

This change adds explicit consistency checks for the minidump early on. The checks are not comprehensive but they should catch obvious structural violations:

- streams with type == 0
- duplicate streams (same type)
- overlapping streams
- truncated minidumps

Another early check is to make sure we actually support the minidump architecture instead of crashing at a random place deep inside LLDB.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49202.155049.patch
Type: text/x-patch
Size: 11353 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180711/d30a7b51/attachment.bin>

More information about the lldb-commits mailing list