[Lldb-commits] [PATCH] D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet

Venkata Ramanaiah via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 10 22:17:30 PDT 2018

ramana-nvr added a comment.

Sorry, I wasn't clear in my previous comment.

In https://reviews.llvm.org/D48868#1158236, @jasonmolenda wrote:

> I don't have strong feelings about removing the m_thread_pcs() in UpdateThreadIDList(), but I think I would prefer leaving it in to changing it unless we know it's causing problems.  Does this cause problems in your environment?

No, it did not cause any problems in our environment.

But it is redundant as UpdateThreadPCsFromStopReplyThreadsValue(), which gets called immediately after clearing m_thread_pcs in UpdateThreadIDList(), will anyway clear the old m_thread_pcs (line 1545 without my changes) before populating them from the thread-pcs: received in the stop reply packet.


More information about the lldb-commits mailing list