[Lldb-commits] [PATCH] D49106: Refactor parsing of option lists with a raw string suffix.

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 154862.
teemperor retitled this revision from "Refactor parsing of argument lists with a raw string suffix." to "Refactor parsing of option lists with a raw string suffix.".
teemperor edited the summary of this revision.
teemperor added a comment.

- Renamed class to OptionsWithRaw
- Changed documentation a bit that it becomes clear this class is more about about parsing command line options.

@jingham Yeah, the class became more option specific while I was trying to get the existing code working. I'm not sure if we have a way to improve the parsing, as depending on the command the input is very ambiguous (e.g. `expr -i0 * -- i` can really be both from the point of the parser). The current code just keeps the behavior of the existing code (which is ok, as that's not the thing the patch wants to fix).


https://reviews.llvm.org/D49106

Files:
  include/lldb/Interpreter/CommandObject.h
  include/lldb/Utility/Args.h
  source/Commands/CommandObjectCommands.cpp
  source/Commands/CommandObjectExpression.cpp
  source/Commands/CommandObjectPlatform.cpp
  source/Commands/CommandObjectType.cpp
  source/Commands/CommandObjectWatchpoint.cpp
  source/Interpreter/CommandObject.cpp
  source/Interpreter/Options.cpp
  source/Utility/Args.cpp
  unittests/Utility/CMakeLists.txt
  unittests/Utility/OptionsWithRawTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49106.154862.patch
Type: text/x-patch
Size: 32422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180710/35617465/attachment-0001.bin>