[Lldb-commits] [PATCH] D48960: Use an unwinder to get register contexts of frames other than zeroth under Windows

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 9 16:19:00 PDT 2018

amccarth added inline comments.

Comment at: source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp:52
   if (!m_reg_context_sp)
-    m_reg_context_sp = CreateRegisterContextForFrameIndex(0);
+    m_reg_context_sp = CreateRegisterContextForZerothFrame();
This bit seems redundant given that CreateRegisterContextForFrameIndex now checks the special case of 0.  It's not a big deal, but I could see someone getting confused while debugging things wondering by CreateRegisterContextForFrameIndex is sometimes called for frame 0 and sometimes not.


More information about the lldb-commits mailing list