[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 9 11:26:12 PDT 2018


apolyakov added inline comments.


================
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py:22
     @skipIfDarwin   # pexpect is known to be unreliable on Darwin
     @skipIfFreeBSD  # llvm.org/pr22411: Failure presumably due to known thread races
     def test_lldbmi_data_disassemble(self):
----------------
aprantl wrote:
> It would be *awesome* if we could also convert this entire to a lit/FileCheck. Looks like all the tests in this file are basically skipped everywhere because it's so unreliable...
It's problematic to convert `data-info-line` test to a lit one since we don't know addresses of a source lines. It means that we can't do this:
`-data-info-line *0xsome_address`


https://reviews.llvm.org/D49062





More information about the lldb-commits mailing list