[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 3 11:04:09 PDT 2018


jankratochvil added inline comments.


================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:520
 $(EXE) : $(OBJECTS) $(ARCHIVE_NAME) $(DYLIB_FILENAME)
 	$(LD) $(OBJECTS) $(ARCHIVE_NAME) -L. -l$(DYLIB_NAME) $(LDFLAGS) -o "$(EXE)"
 else
----------------
Shouldn't be $(LLVM_DWP) even here? DWZ mode has its command even here.


================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:546
 	$(OBJCOPY) --strip-debug --add-gnu-debuglink="$(DSYM)" "$(EXE)" "$(EXE)"
 endif
 endif
----------------
Shouldn't be $(LLVM_DWP) even here? DWZ mode has its command even here.


https://reviews.llvm.org/D48782





More information about the lldb-commits mailing list