[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/lldb/API/SBModule.h:136
+  ///
+  /// @param[in] sb_file_spec
+  ///     A lldb::SBFileSpec object that contains source file
----------------
We typically use `\param` instead of `@param` in LLVM.


================
Comment at: packages/Python/lldbsuite/test/python_api/module_section/TestModuleAndSection.py:151
+        self.setTearDownCleanup(dictionary=d)
+        self.find_compile_units('b.out')
+
----------------
shouldn't this be self.getBuildArtifact('b.out')?


================
Comment at: packages/Python/lldbsuite/test/python_api/target/TestTargetAPI.py:54
+        self.setTearDownCleanup(dictionary=d)
+        self.find_compile_units('b.out')
+
----------------
shouldn't this be `self.getBuildArtifact('b.out')`?


https://reviews.llvm.org/D48801