[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 2 08:37:45 PDT 2018


Sure, that also sounds fine.

Jim


> On Jun 29, 2018, at 11:55 AM, Dave Lee via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> kastiglione added a comment.
> 
> Thanks @jingham.
> 
>> if the `IOHandlerDelegate` could say whether it wants to be notified for `IOHandlerActivated` when non-interactive (like have a "`ShouldNotifyWhenNonInteractive`" method), and then the `IOHandler` could dispatch it or not based on the response to that method
> 
> So the "`ShouldNotifyWhenNonInteractive`" would only control whether `IOHandlerActivated` is called, not any of the other `IOHandlerDelegate` methods?
> 
> What do you think about adding a `IOHandlerActivatedInteractively`delegate method? This could be called in addition to `IOHandlerActivatedInteractively`, but only for interactive IO?
> 
> 
> https://reviews.llvm.org/D48752
> 
> 
> 



More information about the lldb-commits mailing list