[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 26 10:05:54 PDT 2018
JDevlieghere added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:157
+ if (entry.tag() != DW_TAG_structure_type &&
+ entry.tag() != DW_TAG_class_type)
> Wait.. we accept both structs and classes in LLDB? Should we also switch over to using DW_TAG_class in clang since that sounds more appropriate anyway?
I'm probably not the right person to answer this. I copied this from HashedNameToDIE:
611 // We don't only want the one true definition, so try and see what we can 612 // find, and only return class or struct DIEs.
More information about the lldb-commits