[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 22 14:57:08 PDT 2018


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:137
+  auto successHandler = [this] {
+    // CODETAG_DEBUG_SESSION_RUNNING_PROG_RECEIVED_SIGINT_PAUSE_PROGRAM
+    if (!CMIDriver::Instance().SetDriverStateRunningDebugging()) {
----------------
Is this a copy&paste error?


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:142
+          MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE),
+          this->m_cmdData.strMiCmd.c_str(),
+          rErrMsg.c_str()));
----------------
Might want to factor this out into a HandleBoolReturnValue helper if it appears more than once.


https://reviews.llvm.org/D47992





More information about the lldb-commits mailing list