[Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 20 11:58:31 PDT 2018


apolyakov added a comment.

In https://reviews.llvm.org/D47991#1138071, @jingham wrote:

> The client won't be expecting a struct return, and will have generated code to take a void return.  If SBError happens to be returned in registers, nothing bad will happen, but if it's returned on the stack, that would corrupt the caller's stack.  Relying on the particular kind of struct return to keep out of trouble seems like a bad practice to me.
>
> Jim


Ok, then I suggest not to increase amount of methods in API doing the same stuff and keep SBError as in/out parameter.


https://reviews.llvm.org/D47991





More information about the lldb-commits mailing list