[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

Frederic Riss via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 19 10:10:30 PDT 2018


friss added inline comments.


================
Comment at: packages/Python/lldbsuite/test/expression_command/xvalue/TestXValuePrinting.py:32
+        self.assertTrue(value.GetError().Success())
+        self.assertEqual(value.GetValueAsUnsigned(), 0)
+
----------------
Could you use a different value than 0? Getting a random zero from memory seems to easy. It would be better to test a real string.


https://reviews.llvm.org/D48303





More information about the lldb-commits mailing list