[Lldb-commits] [PATCH] D48272: Replace HostInfo::GetLLDBPath with specific functions

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 18 03:57:23 PDT 2018


labath created this revision.
labath added reviewers: clayborg, zturner.

Instead of a function taking an enum value determining which path to
return, we now have a suite of functions, each returning a single path
kind. This makes it easy to move the python-path function into a
specific plugin in a follow-up commit.

All the users of GetLLDBPath were converted to call specific functions
instead. Most of them were hard-coding the enum value anyway, so this
conversion was simple. The only exception was SBHostOS, which I've
changed to use a switch on the incoming enum value.


https://reviews.llvm.org/D48272

Files:
  include/lldb/Host/HostInfoBase.h
  source/API/SBHostOS.cpp
  source/Core/Debugger.cpp
  source/Core/PluginManager.cpp
  source/Expression/REPL.cpp
  source/Host/common/Host.cpp
  source/Host/common/HostInfoBase.cpp
  source/Host/macosx/objcxx/Host.mm
  source/Host/macosx/objcxx/HostInfoMacOSX.mm
  source/Host/posix/HostInfoPosix.cpp
  source/Host/posix/PipePosix.cpp
  source/Host/windows/Host.cpp
  source/Host/windows/HostInfoWindows.cpp
  source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  source/Plugins/ExpressionParser/Clang/ClangHost.cpp
  source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
  unittests/Target/ModuleCacheTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48272.151683.patch
Type: text/x-patch
Size: 30525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180618/b82c5c76/attachment-0001.bin>


More information about the lldb-commits mailing list