[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer
Kuba (Brecka) Mracek via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 15 14:18:36 PDT 2018
kubamracek added a comment.
In https://reviews.llvm.org/D44603#1133149, @jingham wrote:
> This is going as I imagined it should, looks great!
> We probably want to turn this on by default for "frame var" or no one will ever discover it. The IDE folks can decide on their own what to do from the SB API's. Since you are doing module filtering and this only triggers when you explicitly run "frame var" I think having it on by default will not be a big deal.
> Does this work with "frame var paths" as well? That is, if I do:
It does not work. The reason is that the current patch is not creating VariableSP objects, so things like m_variable_list_sp (in StackFrame) don't contain these new "recognized arguments". Right now, I'm just creating ValueObjects and GetVariableList/GetInScopeVariableList doesn't know about them. Do you think we should go that way instead? In that case I think we'd need to extend or subclass Variable so that we can actually create Variable objects that are not backed by DWARF and SymbolContextScope and stuff like that.
If you think that makes sense, I'll be happy to work on that. Also, if you think it's not necessary for an initial commit, I can send a separate follow-up patch (to avoid growing this already large patch).
More information about the lldb-commits