[Lldb-commits] [PATCH] D48215: Remove dependency from Host to python

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 15 07:48:50 PDT 2018

clayborg added inline comments.

Comment at: source/API/SBHostOS.cpp:48
+  case ePathTypePythonDir:
+    fspec = ScriptInterpreterPython::GetPythonDir();
+    break;
Why is this here instead of inside of "HostInfo::GetLLDBPath(path_type, fspec);"? Does this mean internal code that calls:

HostInfo::GetLLDBPath(ePathTypePythonDir, fspec);

Won't work anymore? Also same for ePathTypeClangDir? Are we trying to solve a layering problems by hosing over internal clients?


More information about the lldb-commits mailing list