[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 12 14:52:20 PDT 2018


davide accepted this revision.
davide added a comment.

LGTM with a nit.



================
Comment at: source/Utility/FileSpec.cpp:18-21
+#include "llvm/ADT/Triple.h"      // for Triple
+#include "llvm/ADT/Twine.h"       // for Twine
+#include "llvm/Support/ErrorOr.h" // for ErrorOr
 #include "llvm/Support/FileSystem.h"
----------------
This comments are really too trivial to be useful. Can you remove them?


Repository:
  rL LLVM

https://reviews.llvm.org/D48084





More information about the lldb-commits mailing list