[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: source/Host/CMakeLists.txt:7
+# Removes all module flags from the current CMAKE_CXX_FLAGS. Used for
+# the Obj-C++ code in lldb which we don't want to build with modules.
+# Reasons for this are that modules with Obj-C++ would require that all
----------------
aprantl wrote:
> ObjC++ or Objective C++
s/Obj-C++/Objective C++/


================
Comment at: source/Host/CMakeLists.txt:8
+# the Obj-C++ code in lldb which we don't want to build with modules.
+# Reasons for this are that modules with Obj-C++ would require that all
+# LLVM/Clang modules are Obj-C++ compatible (which they are most likely
----------------
s/Obj-C++/Objective C++/


================
Comment at: source/Host/CMakeLists.txt:108
+    add_subdirectory(macosx/objcxx)
+    set(LLDBObjCLibs lldbHostMacOSXObjCxx)
+    add_host_subdirectory(maqcosx
----------------
either `...objcxx` or `...ObjCXX` 


https://reviews.llvm.org/D47929