[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 12 12:19:55 PDT 2018

labath added inline comments.

Comment at: source/Utility/FileSpec.cpp:244-246
+  // Only update style if explicitly requested.
+  if (style)
+    m_style = (*style == Style::native) ? GetNativeStyle() : *style;
I don't really have a clear opinion on whether the new behaviour here is better or not, but it any case this sounds like something worth explicitly calling out.

Comment at: unittests/Utility/FileSpecTest.cpp:284
-    "//a",
Any particular reason for removing this?



More information about the lldb-commits mailing list