[Lldb-commits] [PATCH] D48060: Introduce lldb-framework CMake target and centralize its logic

[Alex Langford via Phabricator via lldb-commits]

xiaobai created this revision.
xiaobai added reviewers: clayborg, labath, sas.
Herald added a subscriber: mgorny.

Currently, the liblldb target is treated as the entire framework when
building LLDB.framework with CMake, and treated only as the actual liblldb
library otherwise. In this patch I aim to at least partially accomplish 2 things:

1. Create a lldb-framework target that acts as the target that handles

generating LLDB.framework. This should make the purpose of the liblldb target
the same, framework or not.

2. Centralize framework generation as much as it makes sense to do so.

I say "partially accomplish" because there are still parts of CMake that treats
liblldb as the framework, and parts of CMake where we can greatly simplify code
with an lldb-framework target.
I am still working out how I think those should best be handled. I uploaded this
patch because I want to get feedback on what I currently have. I also think this
is a relatively self-contained change, because the build produces the same thing
with and without this change (based on examining the build trees of both).


https://reviews.llvm.org/D48060

Files:
  CMakeLists.txt
  cmake/modules/LLDBFramework.cmake
  source/API/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48060.150881.patch
Type: text/x-patch
Size: 6678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180612/eec6ae22/attachment.bin>