[Lldb-commits] [PATCH] D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails

[Leonard Mosescu via Phabricator via lldb-commits]

lemo added subscribers: amccarth, clayborg, zturner.
lemo added a comment.

> remove space before (

I'd be happy to make the change, but looking at the rest of the file it
seems that almost everything uses the opposite convention: Foo (...).

So, to make sure I'm making the right change, is this how it should look?

  lldb::SBProcess
  LoadCore(const char *core_file);
  
  lldb::SBProcess
  LoadCore(const char *core_file, lldb::SBError &error);


https://reviews.llvm.org/D48049