[Lldb-commits] [PATCH] D47991: Add method SBThread::StepOver with SBError parameter.

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

Sorry for coming in late (WWDC...)  It does seem asymmetric to only have one stepping API take an error.  If one is going to they all should.

You need to add the new API to the SBThread.i file as well or it won't get exported to Python.

Beyond that, the SBError parameter is the last parameter in pretty much all the other SB API's.  We do inputs first and outputs second as a general rule.  So if you are going to add one here it would be better to make it the last parameters.

BTW, the web docs are auto-generated but not live.  I don't remember when somebody last refreshed them (and actually I didn't follow in detail how this was done.)  But we should kick that as an additional step.


https://reviews.llvm.org/D47991