[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

Leonard Mosescu via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 8 10:01:54 PDT 2018

Doesn't the LIT based test drop the split-function case (originally
produced with PGO)?

Sorry for being late to the party, but it seems beneficial to have both LIT
*and* checked in binaries since in general they are complementary: checking
against freshly built binaries only covers a matching set of toolchain
components (in particular it's hard to cover the cross-targeting scenarios).

Other than the inconvenience with Phabricator, is there a reason not to
include the original tests as well? The size of the binaries?

On Fri, Jun 8, 2018 at 1:27 AM, Pavel Labath via Phabricator via
lldb-commits <lldb-commits at lists.llvm.org> wrote:

> labath added a comment.
> Thank you for your patience. I am very happy with the final result here.
> I personally like to keep number of files in a test minimal (hence I
> inlined the test into the cpp file), but overall that's not really
> important.
> https://reviews.llvm.org/D47708
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180608/c022ca1d/attachment.html>

More information about the lldb-commits mailing list