[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

Aaron Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 6 14:20:36 PDT 2018


asmith added a comment.

In https://reviews.llvm.org/D47708#1123334, @labath wrote:

> I have reverted this because of the broken tests.
>
> However, I have to also ask: isn't there better way to test this? (one that does not depend on opaque checked-in binaries). On linux, I could check-in a .s file which has the line table exactly as I want it and then have the test assert that. Is there some suitable intermediate form here?
>
> It seems that lld tests use some yaml form to store pdb's. Is there any chance we could do the same?


I wish these binaries didn’t exist too. Im not sure if the lld approach works because I think we need the VS generated PDBs for function level testing. Maybe Zachary as a better idea.


https://reviews.llvm.org/D47708





More information about the lldb-commits mailing list